[PB-6503] Update private sharings - #2116
Conversation
Deploying drive-web with
|
| Latest commit: |
fc2c736
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be20d9d8.drive-web.pages.dev |
| Branch Preview URL: | https://update-private-sharings.drive-web.pages.dev |
23eff4e to
8cbf76d
Compare
|
@CandelR @larryrider @xabg2 Server side is merged, all should work |
| return new NetworkFacade( | ||
| type DownloadFileFunction = (params: DownloadSharedFileParams | DownloadOwnFile) => DownloadFileResponse; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Which comment? It is a function description. You mean remove it?
There was a problem hiding this comment.
It is pretty redundant that createNetworkFacade creates a Network Facade. No need to have a comment explaining that.
| key: { bucketKey }, | ||
| options, | ||
| } = params; | ||
| async function multipartDownloadOwnFile(params: DownloadOwnFile & { fileSize: number }): Promise<FileStream> { |
| }, | ||
| ), | ||
| ); | ||
| async function multipartDownloadSharedFile( |
| if (shareCredentials?.bucketKey) return { bucketKey: shareCredentials.bucketKey }; | ||
| return { mnemonic: shareCredentials?.mnemonic ?? credentials.key.mnemonic }; |
There was a problem hiding this comment.
I understand that this is because v3 uses a bucketKey, and if there is no bucketKey, does that mean v2? Is that right?
There was a problem hiding this comment.
yes, hybrid works with mnemonic, and hybrid-v2 works with bucketKey. If not set properly, the download will fail
P.S. v3 is for public sharing because it has v2 already
|
4 participants
Description
Adds a new version of private file and folder sharing - based on a bucket key instead of a mnemonic. This implies changes in pretty much everything download-related.
P.S. It also adds multipart download for shared folders. Since multipart had to be changed anyway, we'll save 1 QA
Related Issues
Fixes BR-2165
Relates to PB-6503
Related Pull Requests
Merged server changes for sharing with non-users
Checklist
Testing Process